omz:forum

    • Register
    • Login
    • Search
    • Recent
    • Popular

    Welcome!

    This is the community forum for my apps Pythonista and Editorial.

    For individual support questions, you can also send an email. If you have a very short question or just want to say hello — I'm @olemoritz on Twitter.


    Pulling stockdata from the Yahoo

    Pythonista
    5
    17
    13132
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • SpotlightKid
      SpotlightKid last edited by

      Small suggestion:

      from datetime import datetime, date
      
      [...]
      
      month = int(datetime.strftime(date.today(), "%m")) - 1
      year = int(datetime.strftime(date.today(), "%Y"))
      

      This can be just written as:

      from datetime import date
      
      month = date.today().month - 1
      year = date.today().year
      

      No need to format the month/year number into a string and then into an integer again.

      1 Reply Last reply Reply Quote 0
      • techteej
        techteej last edited by

        @SpotlightKid whoops! Copied from another program and forgot to take that out. Thanks!

        1 Reply Last reply Reply Quote 0
        • techteej
          techteej last edited by

          How would I tweak this to show data for a certain stock? Like APPL for example?

          1 Reply Last reply Reply Quote 0
          • ccc
            ccc last edited by

            Change the last line to: filename, headers = pulldata("AAPL", "AAPL-data.csv")

            Exersize for the reader: Where is the "January Bug" in the code above and how would you fix it?

            1 Reply Last reply Reply Quote 0
            • techteej
              techteej last edited by

              Can't find the January bug , and would like to print the name of the stock if possible

              1 Reply Last reply Reply Quote 0
              • ccc
                ccc last edited by

                Hint 1:

                stock_dict = { 'AAPL' : 'Apple, Inc.',
                               'GOOG' : 'Google',
                               'HPQ'  : 'Hewlett-Packard Company',
                               'IBM'  : 'Internationa Business Machines Corp.' }
                
                for s in 'AAPL GOOG HPQ IBM COKE'.split():
                    print(stock_dict.get(s, 'Unknown'))
                

                Hint 2: You will only see the January Bug when the current month is January... In six weeks it will become clear.

                1 Reply Last reply Reply Quote 0
                • JonB
                  JonB last edited by

                  Ok, I'm stumped ccc. Since python dates use a 1-based month, (January is 1), the above will result in the variable month==0, which is how yahoo wants the data (yahoo uses 0 based month, yet 1 based day for whatever reason).
                  Manually creating a date object in January and using the above code works fine.

                  There is one bug and one quirk that I see:
                  The bug happens st the stroke of midnight on 12/31, in which case the first call to today, to get the month, will return December, but the next call to today, to get the year, will return next year. Thus you won't pull any data (yahoo will return html rather than csv when the dates are in the future)

                  The quirk is that techteejs proposal of pulling data from the start of the current month is not how most people look at stock data.... Last 30 days, sure, but on the first of the month you might not pull any data if the market is not open( for example, market is always closed on January first, so of you ran the script on January first, yahoo would return a file not found error html)

                  Here's a version that pulls last 30 days, and only calls today() once.

                  from datetime import datetime, date, timedelta
                  import urllib
                  
                  enddate = date.today()
                  startdate = enddate + timedelta(-30)
                  
                  STOCK_URL = 'http://ichart.finance.yahoo.com/table.csv'
                  PARAMS = {
                      'a': startdate.month-1,
                      'b': startdate.day,
                      'c': startdate.year,
                      'd': enddate.month-1,
                      'e': enddate.day,
                      'f': enddate.year,
                      'g': 'd',
                      'ignore': '.csv'
                  }
                  
                  def pulldata(stock, filename):
                      params = PARAMS.copy()
                      params['s'] = stock
                      url = "%s?%s" % (STOCK_URL, urllib.urlencode(params))
                      return urllib.urlretrieve(url, filename)
                  
                  filename, headers = pulldata("^RUT", "RUT-data.csv")
                  
                  1 Reply Last reply Reply Quote 0
                  • ccc
                    ccc last edited by

                    Ahhh... You have it right and I had it wrong. Your analysis and code above is the correct approach.

                    1 Reply Last reply Reply Quote 0
                    • techteej
                      techteej last edited by

                      @JonB originally I had planned to have it retrieve last months data if ran on the first and it was a weekend.

                      @ccc Any way to put the stock name in the .csv? I would like to make this for more than one stock.

                      1 Reply Last reply Reply Quote 0
                      • SpotlightKid
                        SpotlightKid last edited by

                        How about putting the month in the filename:

                        filename = "data-%s-%02i.csv" % (stock.replace('^', ''), startdate.month)
                        
                        1 Reply Last reply Reply Quote 0
                        • First post
                          Last post
                        Powered by NodeBB Forums | Contributors