Prevent duplicate launch from shortcut
-
last edited byIs there a good, canonical way to prevent a script from launching again if there is already an instance running? Specifically, I want to prevent the scenario where a user launches the script from the home screen via an app shortcut, then goes back to the home screen and launches it again.
Right now that causes duplicate instances of my script to run. My current method is to have the first instance put a small token in its directory which any other instance can look for and immediately return without running if it isn't the owner of that token. The token is removed by the first instance at exit. This requires quite a bit of careful negotiation and has many difficult edge cases...so I would prefer some simpler way to make sure only a single instance of the script can be running at any time.
-
last edited by@shinyformica
Are you talking from the wrench/play button, or from a url scheme? Presumably you are talking about something with a UI... Fullscreens, panel, sheet or popover?Presumably it is sufficient to see if the UI is present in the app's view heirarchy?
If so the simplest is to use a tag. Code below is from the mapview thread, by omz:
# ... existing_view = toolbar.viewWithTag_(42) if existing_view: existing_view.removeFromSuperview() ObjCInstance(replacement_view).setTag_(42) toolbar.addSubview_(replacement_view) # ..In your case you would use different logic upon detecting existing_view, and might use the UIApplication root view, instead of toolbar, or at least the view you know is root to the way you are presenting.
Also, since the
uimodule, or anything else in site packages doesn't get cleared from sys.modules, you could store a weakref to your object in ui, then check if it still exists. For sure that works with play and wrench, not 100% sure about url scheme launches.If your module is in site-packages, you could also implement a singleton pattern in your class -- storing your instance as a class variable. Your module needs to be in site packages or begin with double underscores (IIRC... See pykit_preflight.py) to survive global clears.
You could also use a global variable for your instance, as long as the name starts with double underscore, it will not be cleared when you run a new script.
If you get your instance via python, then you could check the ovjcinstance's superview() to see if it is still in the view heirarchy. (Iirc on_screen returns false for panels when you are in the editor, but the objc superview is pretty solid way to see if it has been closed)
-
last edited byAs I said, this is for when the user launches the script via a shortcut on the home screen...so I assume that's a URL scheme type of launch.
It's a UI, a fullscreen present(). I like the idea of using a singleton pattern, or storing info in the globals that don't clear between runs for it...I'll give that a try first.
-
last edited byhmm, it turns out when the view is not on the screen, even for panel, it is removed from the view heirarchy... this is different from what i remember.
-
last edited byWell...I tried a few different approaches to this, mainly looking at this thread with info about how Pythonista clears the global state when a script runs:
Unfortunately, none of my approaches worked for when the script is re-launched via a home screen shortcut. In that case, it seems that Pythonista does a harder reset of state, and the running instance loses access to the modules and module-level variables that it had (they all get set to None, if I print the key/value pairs in the globals() dictionary). I can't think of a simple way to prevent that from happening.
For now, for my purposes, I am simply making my script run by default via the pythonista_startup.py when deployed, which is good enough. I may have to revisit going through the process of making it a "true" app via the pythonista Xcode template.
-
last edited byCheck if the imports are in sys.modules. usually when globals are cleared, the modules in site-packages are not, but you lose the globals that reference the module.
The trick is all callback methods need to import any modules within the method itself.
-
last edited by@shinyformica, I have the same issue and have come up with a solution based on a simple protocol. When applications follow the protocol, they will not "pile up on top of one another" when launched from the iOS home screen:
- When an app is already active in Pythonista and it is launched again with its home screen shortcut, the new instance of the app detects the situation and exits, leaving the already active instance of the app on screen.
- When an app is launched from its home screen shortcut and a previous app is already active in Pythonista, the previous app will be notified that it should terminate, its main UI view will be closed, and the new app will be launched.
Protocol
-
An application should create an instance of class AppSingleLaunch, and use it to test if the application is already active, using the is_active() method. If yes, the application should simply exit. If not, the application should declare its main UI view, using the will_present() method, and present the view. Here is an example:
import app_single_launch app = AppSingleLaunch("MyApp") if not app.is_active(): view = MyAppView(app) app.will_present(view) view.present() -
An application should make a call to the AppSingleLaunch.will_close() method, from the will_close() method of its main UI view:
class MyAppView(ui.View): def __init__(self, app): self.app = app def will_close(self): self.app.will_close()
Demo
Save the code for app_single_launch.py and the two demo apps in the same directory.
Define home screen shortcuts for the two demo apps.
Launch demo app 1 using its home screen shortcut, type some text in the text field, then relaunch the app using its home screen shortcut : the text typed previously is still showing, meaning we are using the first launched instance, not the second one. Closing the app brings us back to the Pythonista IDE, not to previously piled up instances of the app.
Launch demo app 1 using its home screen shortcut, then Launch demo app 2 using its home screen shortcut, then close it : the Pythonista IDE shows, not a piled up instance of demo app 1.
Et voilà !
app_single_launch.py
""" Ensure a Pythonista script can only be launched once from the iOS home screen. This module provides a solution to the problem stated by shinyformica, which I have also encountered (https://forum.omz-software.com/topic/5440/prevent- duplicate-launch-from-shortcut): "Is there a good, canonical way to prevent a script from launching again if there is already an instance running? Specifically, I want to prevent the scenario where a user launches the script from the home screen via an app shortcut, then goes back to the home screen and launches it again."" The solution is based on a simple protocol, which applications need to adhere to. When this is the case, applications will not "pile up on top of one another" when launched from the iOS home screen: - When an app is already active in Pythonista and it is launched again with its home screen shortcut, the new instance of the app detects the situation and exits, leaving the already active instance of the app on screen. - When an app is launched from its home screen shortcut and a previous app is already active in Pythonista, the previous app will be notified that it should terminate, its main UI view will be closed, and the new app will be launched. Protocol: 1) An application should create an instance of class AppSingleLaunch, and use it to test if the application is already active, using the is_active() method. If yes, the application should simply exit. If not, the application should declare its main UI view, using the will_present() method, and present the view. Here is an example: import app_single_launch app = AppSingleLaunch("MyApp") if not app.is_active(): view = MyAppView(app) app.will_present(view) view.present() 2) An application should make a call to the AppSingleLaunch.will_close() method, from the will_close() method of its main UI view: class MyAppView(ui.View): def __init__(self, app): self.app = app def will_close(self): self.app.will_close() Implementation: in order to achieve the desired result, we need to remember the last application launched according to the protocol, to determine if it is still active, and, if it is, to close it. This is achieved by storing into a lock file some information about the last application launched: - Its name, as passed to single_launch.launching() - The id of the ui.View instance for its main view, as passed to single_launch. launching(). This is later used to determine if the view is still on screen (when an object is still associated with the id), and to close the app's view. After several tests, it turns out we must use an ui.View object for this purpose, as they seem to persist better than other objects after the cleanup pykit-preflight.py does when an app is launched from the home screen. The location of the lock file is defined by global variable LOCK_PATH. The default location is in the 'site-packages' directory. Known issue: - When an app is on screen, then launched again from its home screen shortcut, some issues may happen with inline import statements (rare, would need to be qualified further). 26-Feb-2019 TPO - Created this module 28-Feb-2019 TPO - Initial release 3-Mar-2019 TPO - Wrapped the code into the AppSingleLaunch class """ import gc import json from pathlib import Path import time from typing import Any import ui __all__ = [ 'AppSingleLaunch', ] DEBUG = False LOCK_PATH = '~/Documents/site-packages/single_launch.lock' def _object_for_id(id_: int) -> Any: """ Return an object, given its id. """ # Do a complete garbage collect, to avoid false positives in case the # object was still in use recently. In the context of AppSingleLaunch, # this would happen if an app was closed, then launched again immediately. gc.collect() for obj in gc.get_objects(): if id(obj) == id_: return obj return None class AppSingleLaunch: """ Wrapper class for all module functionnality. """ def __init__(self, app: str): """ Initialize an AppSingleLaunch instance. Arguments: - app: application name, which should be unique (but this is not enforced). """ self.app = app def is_active(self) -> bool: """ Test if the application is already active. Returns: - True if the application is already running, in which case the caller should do nothing and exit. - False if the application is not already running, in which case the caller should launch the application in a normal way, and declare its main view by calling the will_present() method.""" if DEBUG: print(f"is_active(), app = {self.app}") lock_path = Path(LOCK_PATH).expanduser() if lock_path.exists(): with open(lock_path) as lock_file: (lock_app, lock_view_id) = tuple(json.load(lock_file)) lock_view = _object_for_id(lock_view_id) if DEBUG: print("- Lock file =", lock_app, lock_view_id, "valid" if lock_view else "invalid") if lock_app == self.app and lock_view: if DEBUG: print(f"- App {self.app} already active") return True if DEBUG: print(f"- App {self.app} not active") return False def will_present(self, view: ui.View) -> None: """ Declare that the application is about to present its main view. Arguments: - view: ui.View instance for the app's main view. """ if DEBUG: print(f"will_present({id(view)}), app = {self.app}") lock_path = Path(LOCK_PATH).expanduser() if lock_path.exists(): with open(lock_path) as lock_file: (lock_app, lock_view_id) = tuple(json.load(lock_file)) lock_view = _object_for_id(lock_view_id) if DEBUG: print("- Lock file =", lock_app, lock_view_id, "valid" if lock_view else "invalid") if lock_app == self.app and lock_view: raise ValueError(f"App {self.app} is already active, cannot " f"call will_present() against it.") else: if lock_view and isinstance(lock_view, ui.View): if DEBUG: print(f"- Closing app {lock_app}") lock_view.close() time.sleep(1) # Required for view to close properly # else: lock is a leftover from a previous Pythonista session # and can be safely ignored. with open(lock_path, 'w') as lock_file: json.dump([self.app, id(view)], lock_file) if DEBUG: print(f"- Launching app {self.app}\n- Lock file =", self.app, id(view)) def will_close(self) -> None: """ Declare that the application is about to close its main view. """ lock_path = Path(LOCK_PATH).expanduser() if lock_path.exists(): with open(lock_path) as lock_file: (lock_app, lock_view_id) = tuple(json.load(lock_file)) if lock_app != self.app: raise ValueError(f"App {self.app} if not active, " f"{lock_app} is active") lock_path.unlink()single_launch_demo1.py
""" app_single_launch demo script #1. """ from app_single_launch import AppSingleLaunch import ui class MainView(ui.View): def __init__(self, app: AppSingleLaunch): self.app = app self.name = "Demo app 1" self.flex = 'WH' self.background_color = 'white' self.add_subview(ui.TextField( width=200, height=30, placeholder="Type some text")) def will_close(self) -> None: self.app.will_close() if __name__ == '__main__': app = AppSingleLaunch("Demo app 1") if not app.is_active(): view = MainView(app) app.will_present(view) view.present()single_launch_demo2.py
""" app_single_launch demo script #2. """ from app_single_launch import AppSingleLaunch import ui class MainView(ui.View): def __init__(self, app: AppSingleLaunch): self.app = app self.name = "Demo app 2" self.flex = 'WH' self.background_color = 'white' self.add_subview(ui.TextField( width=200, height=30, placeholder="Type some text")) def will_close(self) -> None: self.app.will_close() if __name__ == '__main__': app = AppSingleLaunch("Demo app 2") if not app.is_active(): view = MainView(app) app.will_present(view) view.present()
