@bosco Thank you. Have used my new dialog lots and still hasn't crashed!

@bosco Brilliant! I can confirm both issues are fixed. You are a star

@bosco Thank you Bosco - I have the new version - still working great!
There are just a couple of small things I noticed.

1. If i default a check value to True eg
   rating_dicts.append(dict(type="check", value = True, title="3"))
   It doesnt show the item with a check against it in the pop up dialog (This just means if I select for example rating =3 then I want to change that later to rating =4 - then I cant 'switch off' the previous rating = 3 and then select rating = 4. I can work around it by clearing all filters and creating a new one.

2. In the Genre dialog that I use - if i scroll down to say New Genre which is a text field when i click on it the dialog scrolls to the top and then the keyboard obscures the field so I cant see what I am typing

Thanks again

@bosco Wow!!! Just want to give you some early feedback - but so far I absolutely love the new dialog - I am doing all the things that usually crash it and its working brilliant! I will carry on using as normal but I am very optimistic. Thanks Bosco you are a genius.

@bosco Great thank you - your new dialog sounds great - I will give it a try and let you know how i get on. Thanks!

@bosco Hi Bosco - do you know what the process is for getting this on the fix list for omz - do i need to raise a change request or something?
Thanks

I certainly can Bosco! - its a familiar experience. That is great that you have found a repeatable way to crash the app. Hopefully this will help diagnose and fix the problem! Great work

@bosco Thats great that you can repeat the crash everytime - this is something I have been trying to do but no success so far as it has been random for me. I hope you can create the simple script to isolate problem as that would be a big step forward. Thanks

@bosco Hi Bosco I have added additional log information into my code and I can confirm that the crash happens inside the dialogs.form_dialog() call - I have code either side of the call that writes to the database with the contents of form_list_of_sections and I can see the data is fine going into the function call. I have code immediatly after the function call to add further logging to the database but this code is never reached. To me this seems like a problem with pythonista itself as there is nothing wrong with the data going in but the function never returns - it crashes on the done button( In looking dialog.py i notice the line that it crashes on is ui.end_editing()). Would you agree with this assessment?

@LankyDonkey Whats odd is that I can use dialogs fine and then when the app is playing some songs and even if I haven't used any dialogs for a while it will suddenly crash - could it be that using the dialogs is making the app unstable - maybe it messes with the memory structure and then a later part of the app overwrites that memory causing a seg fault. So it may not be the action I do at the time that causes the crash but a previous action that has put it into an unstable state. I don't really understand these segmentation faults but it appears to be related to memory being used that shouldnt.