CaptureMedia

Thanks

@ccc I've added some notes above regarding the purpose of the items removed in the Github edit.

Here's an example of how to make a custom CaptureMedia with the version posted here (this wouldn't work with the GitHub edit)...

class MyCaptureMedia (CaptureMedia):
	def did_load(self):
		self.name = 'My Capture Media'
		self.background_color = 'Lime'
		self.left_button_items = [ui.ButtonItem(image = ui.Image.named('ionicons-close-24'), action = lambda sender: self.close())]
		self.lHelp = ui.Label()
		self.lHelp.text = 'Please choose media...'
		self.add_subview(self.lHelp)
		super(MyCaptureMedia, self).did_load()
		
	def layout(self):
		self.width = 320
		self.height = 200
		self.lHelp.x = 30
		self.lHelp.y = 10
		self.lHelp.width = 180
		self.lHelp.height = 30

ccc

@Tony, Thanks for the explanations on the desire for extension points and log_message(). Makes sense to me. I posted a pull request to re-add log_message() and will try to put the extension points back into the GitHub source in the next 24 hours (if someone does not do so before I can).

Can we come up with a different name for did_load()? Ole had reserved the did_load() name for views that load ui resources from a .pyui file. A did_load() in a script that does not use .pyui might confuse the casual reader. Given that all ui elements are created at runtime without .pyui, we should use a similar yet different name.

@ccc Good. Maybe... consider though... should the consumer of a class need to know or bother whether behind the scenes it's ui was implemented with the ui editor or with handwritten code?? The use of did_load here was deliberate to create consistency and transparency.

ccc

I submitted a pull request which I hope solves the issues that you mentioned above.

I also opened a new issue on cancel and close.

@ccc Well done. Yes, it's a good point about detecting the cancel. The evaluate JavaScript returns immediately so that doesn't help. There's no POST when the user cancels... so again that doesn't help. It's hard to wait for an absence of the file when there's no knowing how long a video record might last.

In the base class... after cancel, tap outside the popover to close it and then the server closes because of the will close.

The sub class close button is the same scenario as the close from the POST I think... it seems to be a quirk of a programmatic close of a view presented in a popover that will_close doesn't automatically get called on the view in that case. Hence the second line at the end of POST to fix that. (present in a panel doesn't have that quirk I think, nor probably the other presents though I haven't tested.)

The sub class was a quick knock up to show the idea, but more properly I think the button item action would need to invoke both will close and close because of the quirk.

@ccc It's a bit of a fudge, but this addition to the base class seems to fix the quirk of present in a popover programmatic close for both the POST and the sub class button item action (and the fix line from POST can be removed)...

def close(self):
		self.will_close()
		super(CaptureMedia, self).close()

Updated source to version 2.0

techteej

@tony Just updated.

@techteej Thanks.

p.s. I'm working on adding in a settings button and my SettingsSheet class for a switch to turn warnings on/off.

techteej

@tony I have to test this on an iOS 7 iPad, which I don't see very often (it's a relatives) so good luck! Hopefully @ccc will help you. I can do what I can when I get the iOS 7 iPad.

@techteej Thanks :) Likewise when iOS 8 is out I'll have a way to try to get it working on that.

jmv38

capture_media generates an error on line 115 on my ipad air ios7.... any fix?

JonB

Looks like you should replace self._f with os.path.split(__file__)[1].
You might also want to try one of the older versions (github history) since it seems like people checked in work without testing.

jmv38

@JonB thanks.
i've replaced the self._f at 2 locations, but there are still errors.
Which version in the history would your recommend?

Webmaster4o

Where is a working link?